Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change test setup to use account helper if available #285

Merged
merged 11 commits into from
Jun 25, 2020
Merged

Change test setup to use account helper if available #285

merged 11 commits into from
Jun 25, 2020

Conversation

vgrichina
Copy link
Contributor

No description provided.

@vgrichina vgrichina requested review from mikedotexe and removed request for mikedotexe April 8, 2020 07:12
@mikedotexe
Copy link
Contributor

The CI is getting:

Sender "test1586329977365474" does not have enough balance 100000000000000000 for operation costing 10000000000000000000000000

@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 5326508 to 5e384d3 Compare April 13, 2020 22:19
@mikedotexe
Copy link
Contributor

CI is failing because:

6:5 error 'testAccount' is assigned a value but never used no-unused-vars

@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 5e384d3 to ed354a2 Compare April 14, 2020 00:40
@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 4e63ef9 to 4bc79bf Compare May 2, 2020 06:41
@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 4bc79bf to c4584da Compare June 24, 2020 03:40
@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 0108672 to 55c7ea6 Compare June 24, 2020 07:52
@vgrichina vgrichina force-pushed the test-setup-using-helper branch from 55c7ea6 to f13356d Compare June 24, 2020 19:25
@vgrichina vgrichina merged commit fa33984 into master Jun 25, 2020
bowenwang1996
bowenwang1996 reviewed Jun 25, 2020
View reviewed changes
.travis.yml
@@ -3,6 +3,8 @@ node_js: 10
env:
- NODE_ENV=ci
- NODE_ENV=ci-betanet
# - NODE_ENV=devnet
- NODE_ENV=betanet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether this is a good idea. If betanet is down, near-api-js development would be blocked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Bowen here, I think it's too early have to have CI check betanet. In time, perhaps

@bowenwang1996 bowenwang1996 mentioned this pull request Jun 25, 2020
Closed
@mikedotexe mikedotexe deleted the test-setup-using-helper branch June 25, 2020 20:41
@vgrichina vgrichina mentioned this pull request Jul 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowenwang1996 bowenwang1996 bowenwang1996 left review comments

@mikedotexe mikedotexe Awaiting requested review from mikedotexe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vgrichina @mikedotexe @bowenwang1996